Fix conditional logic for enemy color assignment #2779
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #2764 Signed-off-by: Aru <[email protected]>
TimtyG
suggested changes
Dec 21, 2025
Contributor
TimtyG
left a comment
TimtyG
left a comment
There was a problem hiding this comment.
the IsAllyOf check retrns true for allies (party/guild members), but the hostile color should be applied to non-allies.
TimtyG
approved these changes
Dec 21, 2025
WeylonSantana
approved these changes
Dec 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2764
Proposed by @kznava
@TimtyG please let us know if this change fixes the issue for you (haven't really reproduced nor tested this yet).
Regards.-